Validation for private projects and confidential leads #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susilnem
force-pushed
the
feature/restrict-autoclustering-summarization
branch
from
ecd9f54
to
35b3b81
Compare
thenav56
requested changes
Jun 12, 2024
| @@ -392,9 +419,11 @@ def test_automatic_summary(self, trigger_results_mock, RequestHelperMock): | |||
| lead1 = LeadFactory.create(project=self.project) | |||
| lead2 = LeadFactory.create(project=self.project) | |||
| another_lead = LeadFactory.create(project=self.another_project) | |||
| lead3 = LeadFactory.create(project=self.private_project) | |||
There was a problem hiding this comment.
Let's create another confidential leads RESTRICTED, CONFIDENTIAL and some entries. Make sure the generated files doesn't include those entries, even if filters allows.
Similar to what we did before here https://github.com/the-deep/server/pull/1502/files#diff-223594694777faf05fef2c6acee1587a281db5d1002813ca7b0e43862d6feda0R256-R268
There was a problem hiding this comment.
For this one, Let's merge the Mentioned PR and Update the fields validation. They are on same function that's why.
There was a problem hiding this comment.
@AdityaKhatri Will merge this #1502. After that, let's confirm the above changes.
susilnem
force-pushed
the
feature/restrict-autoclustering-summarization
branch
2 times, most recently
from
ad9e2f9
to
afd6d2b
Compare
AdityaKhatri
force-pushed
the
feature/restrict-autoclustering-summarization
branch
from
afd6d2b
to
0280d25
Compare
susilnem
force-pushed
the
feature/restrict-autoclustering-summarization
branch
from
0280d25
to
39d2fec
Compare
PR changes Update side_effect function for checking Confidential leads
susilnem
force-pushed
the
feature/restrict-autoclustering-summarization
branch
from
39d2fec
to
388a807
Compare
sudan45
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Changes
Mention related users here if any.
This PR doesn't introduce any:
printThis PR contains valid: