UserAuth prevent plugin errors (like the Nextcloud plugin did)

the-djmaze · May 27, 2024 · 365a5ef · 365a5ef
1 parent 69cd876
commit 365a5ef
Showing 1 changed file with 18 additions and 7 deletions.
diff --git a/snappymail/v/0.0.0/app/libraries/RainLoop/Actions/UserAuth.php b/snappymail/v/0.0.0/app/libraries/RainLoop/Actions/UserAuth.php
@@ -37,7 +37,11 @@ protected function resolveLoginCredentials(string $sEmail, SensitiveString $oPas
 	{
 		$sEmail = \SnappyMail\IDN::emailToAscii(\MailSo\Base\Utils::Trim($sEmail));
 
-		$this->Plugins()->RunHook('login.credentials.step-1', array(&$sEmail));
+		$sNewEmail = $sEmail;
+		$this->Plugins()->RunHook('login.credentials.step-1', array(&$sNewEmail));
+		if ($sNewEmail) {
+			$sEmail = $sNewEmail;
+		}
 
 		$oDomain = null;
 		$oDomainProvider = $this->DomainProvider();
@@ -98,9 +102,13 @@ protected function resolveLoginCredentials(string $sEmail, SensitiveString $oPas
 			}
 		}
 
-		$sPassword = (string) $oPassword;
-		$this->Plugins()->RunHook('login.credentials.step-2', array(&$sEmail, &$sPassword));
+		$sNewEmail = $sEmail;
+		$sPassword = $oPassword->getValue();
+		$this->Plugins()->RunHook('login.credentials.step-2', array(&$sNewEmail, &$sPassword));
 		$this->logMask($sPassword);
+		if ($sNewEmail) {
+			$sEmail = $sNewEmail;
+		}
 
 		$sImapUser = $sEmail;
 		$sSmtpUser = $sEmail;
@@ -112,15 +120,18 @@ protected function resolveLoginCredentials(string $sEmail, SensitiveString $oPas
 			$sSmtpUser = $oDomain->SmtpSettings()->fixUsername($sSmtpUser);
 		}
 
-		$this->Plugins()->RunHook('login.credentials', array(&$sEmail, &$sImapUser, &$sPassword, &$sSmtpUser));
+		$sNewEmail = $sEmail;
+		$sNewImapUser = $sImapUser;
+		$sNewSmtpUser = $sSmtpUser;
+		$this->Plugins()->RunHook('login.credentials', array(&$sNewEmail, &$sNewImapUser, &$sPassword, &$sNewSmtpUser));
 
 		$oPassword->setValue($sPassword);
 
 		return [
-			'email' => $sEmail,
+			'email' => $sNewEmail ?: $sEmail,
 			'domain' => $oDomain,
-			'imapUser' => $sImapUser,
-			'smtpUser' => $sSmtpUser,
+			'imapUser' => $sNewImapUser ?: $sImapUser,
+			'smtpUser' => $sNewSmtpUser ?: $sSmtpUser,
 			'pass' => $oPassword
 		];
 	}