TOTP plugin is dependent on ctype

[msimerson]

The Bug

Unable to set up the Two factor plugin due to undeclared dependency on PHP ctype plugin.

To Reproduce

1. install snappymail
2. verify all the PHP plugins are present in Admin -> About -> PHP optional extensions
3. Enable Extensions -> Two Factor Authentication
4. Log in a normal user
5. Attempt to Activate TOTP in the UI
6. Page fails to load UI for setting up TOTP
7. Enable Snappymail application logs
8. Determine what this entry means:

[2023-09-20 22:16:09.957][ad7382c3] SERVICE[WARNING]: Call to undefined function ctype_digit()
#0 /usr/local/www/snappymail/snappymail/v/2.28.4/app/libraries/snappymail/qrcode.php(1031): SnappyMail\QRData::detectMode()
#1 /usr/local/www/snappymail/snappymail/v/2.28.4/app/libraries/snappymail/qrcode.php(99): SnappyMail\QRData->__construct()
#2 /usr/local/www/snappymail/snappymail/v/2.28.4/app/libraries/snappymail/qrcode.php(425): SnappyMail\QRCode->addData()
#3 /data/_data_/_default_/plugins/two-factor-auth/index.php(138): SnappyMail\QRCode::getMinimumQRCode()
#4 /data/_data_/_default_/plugins/two-factor-auth/index.php(126): TwoFactorAuthPlugin::getQRCode()
#5 /usr/local/www/snappymail/snappymail/v/2.28.4/app/libraries/RainLoop/Plugins/Manager.php(372): TwoFactorAuthPlugin->DoCreateTwoFactorSecret()
#6 /usr/local/www/snappymail/snappymail/v/2.28.4/app/libraries/RainLoop/ServiceActions.php(145): RainLoop\Plugins\Manager->RunAdditionalJson()
#7 /usr/local/www/snappymail/snappymail/v/2.28.4/app/libraries/RainLoop/Service.php(132): RainLoop\ServiceActions->ServiceJson()
#8 /usr/local/www/snappymail/snappymail/v/2.28.4/app/libraries/RainLoop/Service.php(14): RainLoop\Service::RunResult()
#9 /usr/local/www/snappymail/snappymail/v/2.28.4/include.php(143): RainLoop\Service::Handle()
#10 /usr/local/www/snappymail/index.php(11): include('...')
#11 {main}

9. Install ctype plugin and restart PHP FPM
10. Rejoice. 🎉

Environment

• Browser: Safari, Firefox, Chrome
• IMAP daemon: dovecot
• PHP version: 8.2.10
• SnappyMail Version: 2.28.4
• Mode: standalone