Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinction between real attachment and inline images attachments #1360

Closed
Massedil opened this issue Dec 13, 2023 · 6 comments
Closed

Distinction between real attachment and inline images attachments #1360

Massedil opened this issue Dec 13, 2023 · 6 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Massedil
Copy link

Is your feature request related to a problem? Please describe.

When I see an HTML message with inline images (Content-ID header on the attachment ?) and only one true attachment (let's say a .pdf file), all images a displayed as an attachment and it is not easy to find the true attachment.

1

Describe the solution you'd like

Inline attachment are :

  • on a second attachment line or
  • reduced or
  • not displayed at all (if I want to save an inline image, I can do it from the e-mail where the image is already displayed)

Examples

Not a real attachment :

Content-Type: image/png;
	name="logoXXXXX";
	charset="ISO-8859-1"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
	filename="logoXXXXX"
Content-ID: <logo>

Not a real attachment :

Content-Type: image/png; name=logo.png
Content-Transfer-Encoding: base64
Content-ID: <logo>
Content-Disposition: inline; filename=logo.png

Real attachment :

Content-Type: application/pdf; name=XXXXXXXXXX.pdf
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename=XXXXXXXXXX.pdf
@the-djmaze
Copy link
Owner

Turn Show inline attachments in list off in your settings.

@Massedil
Copy link
Author

Turn Show inline attachments in list off in your settings.

I don't know where this option is.

I search in admin settings panel and in user settings panel.

(Or may be it is strangely translated in French ?)

@the-djmaze
Copy link
Owner

the-djmaze commented Dec 14, 2023

User settings "Afficher les pièces jointes dans la list"

@the-djmaze the-djmaze added the external Issue is outside our code label Dec 14, 2023
@Massedil
Copy link
Author

  1. Unchecking this checkbox effectively remove all inline attachments from the attachment zone, thanks.

  2. "Afficher les pièces jointes dans la liste" just means "display attachment in the list". I think you should update the translation to something like "Afficher les pièces jointes intégrées dans la liste" even if I imagine, like in English, people don't understand what are "inline" attachment.

  3. May be a separation between inline and "normal" attachment can be easier for users. Like a menu "more attachment" to see inline attachments.

@the-djmaze the-djmaze removed the external Issue is outside our code label Dec 14, 2023
the-djmaze pushed a commit that referenced this issue Dec 17, 2023
@the-djmaze
Copy link
Owner

the-djmaze commented Dec 17, 2023

3. May be a separation between inline and "normal" attachment can be easier for users. Like a menu "more attachment" to see inline attachments.

If you look carefully there's a chain with the inline attachments.

@Massedil
Copy link
Author

Massedil commented Dec 17, 2023

If you look carefully there's a chain with the inline attachments.

Exact ! I havn’t seen it before now ! :)

@the-djmaze the-djmaze added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants