Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Squire] Switch between HTML <-> Source changes mail body #1815

Closed
phsc84 opened this issue Oct 17, 2024 · 4 comments
Closed

[Squire] Switch between HTML <-> Source changes mail body #1815

phsc84 opened this issue Oct 17, 2024 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@phsc84
Copy link

phsc84 commented Oct 17, 2024

Describe the bug
The button "HTML <-> Source" should just switch the view but not delete elements from the mail body.

To Reproduce
Steps to reproduce the behavior:

  1. Open any mail.
  2. Click reply or reply all.
  3. Click on the "HTML <-> Source" button to get to the HTML source.
  4. The mail starts with: <div><br><br></div><p>October 17, 2024...
  5. Click twice on the "HTML <-> Source" button to get back to the formatted view and forth to the HTML source.
  6. The mail starts with: <div><br></div><p>October 17, 2024
  7. Again, click twice on the "HTML <-> Source" button to get back to the formatted view and forth to the HTML source.
  8. The mail starts with: <p>October 17, 2024

After this procedure you can click on the "HTML <-> Source" button as much as you want, but nothing will change anymore.

Expected behavior
The "HTML <-> Source" button should not change anything in the HTML source.

Screenshots
If applicable, add screenshots to help explain your problem.

Please complete the following information:

  • Browser: Chrome 129
  • SnappyMail Version: 2.38.2
  • Mode: standalone
@phsc84
Copy link
Author

phsc84 commented Oct 18, 2024

Something very similar also happens when you paste something:

  1. Open any mail.
  2. Click reply or reply all.
  3. The mail starts with: <div><br><br></div><p>October 17, 2024...
  4. Paste something (e.g. "test", it does not matter if some text or a link) into the mail answer.
  5. One line disappears and the mail starts with: <div>test<br></div><p>October 17, 2024...

@the-djmaze
Copy link
Owner

Actually this is a side effect of bugs in browsers.
I explain here: #1389 (comment)

Maybe Squire should just always add the <br> at html mode or not remove the br at export.

But it will also be an issue on save as draft and edit again.

This has to be thought out big time how to solve.

the-djmaze pushed a commit to the-djmaze/Squire that referenced this issue Oct 27, 2024
@the-djmaze the-djmaze added the enhancement New feature or request label Oct 27, 2024
@the-djmaze the-djmaze added the bug Something isn't working label Oct 27, 2024
@phsc84
Copy link
Author

phsc84 commented Nov 19, 2024

@the-djmaze
How about a new release? Would love to test this as well!

@the-djmaze
Copy link
Owner

Soon, had some other priorities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants