Properly escape path separator in tar.php
file list regex
#1562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
tar.php
, the regex delimiter/
is not properly escaped when building the$files
regex list. This results in the incorrect regex/^(snappymail/)/u
on my system. I don't know why seemingly no one else has run into this as I have been unable to find any GH issues related to it. For reference I am running Alpine Linux which uses the Busybox userland and musl libc.This PR replaces the
array_map
callable with an anonymous function that adds thedelimiter
argument topreg_quote
. The bad regex above is correctly translated into/^(snappymail\/)/u
after applying the patch.