Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dmarc and spf indicators in mail view #1843

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

edlerd
Copy link

@edlerd edlerd commented Nov 12, 2024

Done

  • Added dmarc and spf indicators, in the same way as the existing dkim icon and hover text

Fixes # #1820

Signed-off-by: David Edler <david.edler@canonical.com>
@the-djmaze the-djmaze added the enhancement New feature or request label Nov 18, 2024
@the-djmaze
Copy link
Owner

the-djmaze commented Nov 18, 2024

There's a problem with you modifications.

"✔✔✔" explains your enhancement
But it is possible to have "✔" or "✔✔"
Which "✔" is missing? dkim? dmarc? spf?

What about just one ✔ or ✖ or ⚠

Or have the empty also have a "no entry" icon 🚫︎
Like:
🚫︎ = none
✔ = pass
✖ = fail

Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd
Copy link
Author

edlerd commented Nov 18, 2024

Thanks for the feedback.

Or have the empty also have a "no entry" icon 🚫︎
Like:
🚫︎ = none
✔ = pass
✖ = fail

I think this is the best and easiest solution. Added the none icon just above with the last commit.

@the-djmaze the-djmaze merged commit 7eaa065 into the-djmaze:master Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants