Fix d4all protections #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnuxie
reviewed
Mar 7, 2024
| @@ -146,9 +135,21 @@ export class ProtectionManager { | |||
| get protections(): Readonly<Map<string /* protection name */, Protection>> { | |||
| return this._protections; | |||
| } | |||
| private readonly protection_classes: Protection[] = [ | |||
There was a problem hiding this comment.
NIT: Let's stick to the naming convention of protectionClasses please, sorry if that's been butchered in some other place.
| ) { | ||
| super() | ||
| const banPropagationProtection = this.protections.find(p => p.name === 'BanPropagationProtection'); |
There was a problem hiding this comment.
would be cool if we could make 'BanPropagationProtection' a static name field on the BanPropagationProtection class so we don't have to risk typoing it. Which would then remove the need for this check
| @@ -146,9 +135,21 @@ export class ProtectionManager { | |||
| get protections(): Readonly<Map<string /* protection name */, Protection>> { | |||
| return this._protections; | |||
| } | |||
| private readonly protection_classes: Protection[] = [ | |||
There was a problem hiding this comment.
Hmm seems like the _protections member is already doing this job...
| @@ -159,7 +160,7 @@ export class ProtectionManager { | |||
| await this.enabledProtectionsManager.start(); | |||
| this.mjolnir.reportManager.on("report.new", this.handleReport.bind(this)); | |||
| this.mjolnir.matrixEmitter.on("room.event", this.handleEvent.bind(this)); | |||
| for (const protection of PROTECTIONS) { | |||
| for (const protection of this.protection_classes) { | |||
There was a problem hiding this comment.
Maybe we could just move the list of protections (formerly) PROTECTIONS to here? and then pass _protections to the EnabledProtectionsManager`?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a long standing bug where we had things activated that didnt seem active. This should now have a clean protection instance per mjolnir instance.