-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to modern yarn with pnpm linking #562
base: main
Are you sure you want to change the base?
Conversation
I'm sure this'll stop exactly nobody but I have no idea how to deal with modern yarn under nix. As far as I can find, the only solution are ugly hacks, or shipping a package-lock.json for plain npm. Ugly hacks are already in use to get draupnir to build with corepack: NixOS/nixpkgs#274052 (comment) I would love to avoid a situation where I have to either choose to not use draupnir at all, or commit heinous crimes to patch all of this out to get it to compile at all. |
Without the previous commit, which I think is wrong, the three errors are:
I wonder if
|
@@ -69,6 +69,7 @@ | |||
"js-yaml": "^4.1.0", | |||
"jsdom": "^24.0.0", | |||
"matrix-appservice-bridge": "^9.0.1", | |||
"matrix-bot-sdk": "^0.7.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did this get added?
We use a new vector fork of the matrix-bot-sdk because of matrix-appservice-bridge, but depending on the version of matrix-appservice-bridge you use, they expect the vector fork to be aliased to "matrix-bot-sdk". The newer versions remove that alias. |
yarn lint
fails since➤ YN0060: │ eslint is listed by your project with version 9.7.0 (p456fe), which doesn't satisfy what typescript-eslint and other dependencies request (^8.56.0).
and I am unsure on whether that is something I am causing.Resolves: #475