Fix typos #2724
Open
Fix typos #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing these may take a lot of time. I let your engineers work on this. |
bordoni
requested changes
Sep 20, 2023
| public function get_ticket_sale_infomation( $ticket_sold, $post_id ) { | ||
| public function get_ticket_sale_information( $ticket_sold, $post_id ) { |
There was a problem hiding this comment.
Here we need to create a method with the correct name and redirect this one to the correct one and call this one deprecated. There are premium add-ons that use this. I will push the change later this week.
| @@ -3279,7 +3279,7 @@ public function get_tickets_unavailable_message( $tickets ) { | |||
| * | |||
| * @param bool $display_date | |||
| */ | |||
| $display_date = apply_filters( 'tribe_tickets_unvailable_message_date', $display_date = true ); | |||
| $display_date = apply_filters( 'tribe_tickets_unavailable_message_date', $display_date = true ); | |||
There was a problem hiding this comment.
Need to be deprecated properly.
There was a problem hiding this comment.
@bordoni Do you mean apply_filters_deprecated?
$display_date = apply_filters_deprecated( 'tribe_tickets_unvailable_message_date', $display_date = true );
$display_date = apply_filters( 'tribe_tickets_unavailable_message_date', $display_date );https://developer.wordpress.org/reference/functions/apply_filters_deprecated/
| @@ -3288,7 +3288,7 @@ public function get_tickets_unavailable_message( $tickets ) { | |||
| * | |||
| * @param bool $display_time | |||
| */ | |||
| $display_time = apply_filters( 'tribe_tickets_unvailable_message_time', $display_time = false ); | |||
| $display_time = apply_filters( 'tribe_tickets_unavailable_message_time', $display_time = false ); | |||
There was a problem hiding this comment.
Need to be deprecated properly.
| @@ -3329,7 +3329,7 @@ public function get_tickets_unavailable_message( $tickets ) { | |||
| * @param string Unavailability message | |||
| * @param array Collection of tickets | |||
| */ | |||
| $message = apply_filters( 'event_tickets_unvailable_message', $message, $tickets ); | |||
| $message = apply_filters( 'event_tickets_unavailable_message', $message, $tickets ); | |||
There was a problem hiding this comment.
Need to be deprecated properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Hello! I've ran
typoson this project and found many typos.Please consider running it on all of your projects.
Fixes