Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTRIA-1256 - fix export attendees via email functionality #3038

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

masoodahmed
Copy link

@masoodahmed masoodahmed commented May 6, 2024

🎫 Ticket

GTRIA-1256

πŸ—’οΈ Description

Updated the logic to check if the email with attendees needs to be sent. Also, updated the conditional to check if status is empty to avoid false success or failure message.

πŸŽ₯ Artifacts

N/A

βœ”οΈ Checklist

  • Changelog entry in the readme.txt file.
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

It used to check if status is false which always prompted a message. Now it verifies if the status is empty or not.
@bordoni bordoni added the code review Status: requires a code review. label May 18, 2024
@bordoni
Copy link
Member

bordoni commented May 18, 2024

This is a great addition to release/T24.asag, @codingmusician can you make sure this gets over the finish line? I will drop a line on the ticket so we keep track of it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Status: requires a code review.
Projects
None yet
2 participants