Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Made string translatable in the getting-started file #3052

Closed
wants to merge 4 commits into from
Closed

Fix: Made string translatable in the getting-started file #3052

wants to merge 4 commits into from

Conversation

DAnn2012
Copy link

@DAnn2012 DAnn2012 commented Jun 2, 2024 •
edited by sdokus
Loading

🎫 Ticket

TECTRIA-303

🗒️ Description

Fix: Made a string translatable in the admin 'Getting Started' links.

🎥 Artifacts

✔️ Checklist

  • Changelog entry in the readme.txt file.
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@bordoni
Copy link
Member

bordoni commented Jun 8, 2024

@sdokus mind owning this to be merged into release/T24.babayaga?

@sdokus sdokus self-assigned this Aug 21, 2024
@sdokus sdokus added code review Status: requires a code review. hold Status: on hold–do not proceed with other status items. needs release Needs an associated release in Jira before merging. needs changelog Needs a changelog entry before merging. labels Aug 21, 2024
@sdokus sdokus changed the base branch from master to release/T24.drac August 26, 2024 22:51
@sdokus sdokus removed the needs release Needs an associated release in Jira before merging. label Aug 26, 2024
@sdokus sdokus changed the title Fix: Made strings translatable in two PHP files Fix: Made string translatable in the getting-started file Aug 26, 2024
@sdokus sdokus removed hold Status: on hold–do not proceed with other status items. needs changelog Needs a changelog entry before merging. labels Aug 26, 2024
@sdokus sdokus mentioned this pull request Aug 27, 2024
Merged
8 tasks
@sdokus sdokus closed this Aug 27, 2024
@sdokus
Copy link
Contributor

sdokus commented Aug 27, 2024

Closing in favor of #3052 to allow our tests to run correctly on the PR.

@sdokus sdokus removed the code review Status: requires a code review. label Aug 27, 2024
@sdokus sdokus removed their assignment Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@DAnn2012 @bordoni @sdokus