Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Attendees CSV Export #3117

Closed
wants to merge 39 commits into from
Closed

Fix Attendees CSV Export #3117

wants to merge 39 commits into from

Conversation

pattihis
Copy link
Contributor

@pattihis pattihis commented Jul 19, 2024 •
edited
Loading

🎫 Ticket

ET-2094

🗒️ Description

In our previous CSV export functions we expected an associated event_id, that would exist as a query parameter. In our main attendees table we are now exporting all of them instead ( event_id=all ).

✔️ Checklist

  • Changelog entry in the readme.txt file.
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

stratease and others added 30 commits July 15, 2024 08:34
@stratease
Merge branch 'bucket/plugin-consolidation' of github.com:the-events-c…
5b5076f 
…alendar/event-tickets into merge-plugin-consolidation
@stratease
Bump common
904677d
@Camwyn
phpcs
f03d5c0
@Camwyn
phpcs
908740f
@stratease
Merge branch 'bucket/order-management' of github.com:the-events-calen…
e53d410 
…dar/event-tickets into merge-plugin-consolidation
@stratease
Bump version.
caaadee
@tec-bot
⏩ the-events-calendar/tribe-common@8206c8c
444e8e4
@tec-bot
⏩ the-events-calendar/tribe-common@35fd8f7
329a8e9
@stratease
Fix notice error, and outdated snapshot
004a106
@tec-bot
⏩ the-events-calendar/tribe-common@bab54d9
5ba2870
@stratease
Fix arg count for 'deprecated_function_run'
380f857
@tec-bot
⏩ the-events-calendar/tribe-common@c93e483
8e0ac3e
@tec-bot
⏩ the-events-calendar/tribe-common@e727ac4
e5f6135
@tec-bot
⏩ the-events-calendar/tribe-common@697b7e8
a581ddc
@tec-bot
⏩ the-events-calendar/tribe-common@e46fcc8
600b895
@tec-bot
⏩ the-events-calendar/tribe-common@0f0866f
92cafd0
@tec-bot
⏩ the-events-calendar/tribe-common@2969471
752ba10
@tec-bot
⏩ the-events-calendar/tribe-common@8685c41
cd7a421
@tec-bot
⏩ the-events-calendar/tribe-common@d09e1e9
e3783d2
@tec-bot
⏩ the-events-calendar/tribe-common@c1496c8
6b10214
@tec-bot
⏩ the-events-calendar/tribe-common@5182aec
866e22e
@stratease
Fix some deprecated api errors.
768aec1
@Camwyn
use merged common hash
5dab29c
@Camwyn
Merge branch 'bucket/plugin-consolidation' into merge-plugin-consolid…
5bb5496 
…ation
@Camwyn
Merge branch 'release/T24.babayaga' into merge-plugin-consolidation
3234730
@Camwyn
typo
533db6b
@stratease
Merge branch 'bucket/plugin-consolidation' into merge-plugin-consolid…
e49086f 
…ation
@Camwyn
Try to ensure 2020 gets used and update some snapshots
ecdbd30
@stratease
Updated snapshot.
03c3887
@tec-bot
⏩ the-events-calendar/tribe-common@44ffe6a
5dc405c
@pattihis pattihis self-assigned this Jul 19, 2024
JPry
JPry requested changes Jul 19, 2024
View reviewed changes
src/Tribe/Attendees.php Outdated Show resolved Hide resolved
src/Tribe/Attendees.php Outdated Show resolved Hide resolved
src/Tribe/Attendees.php Outdated Show resolved Hide resolved
src/Tribe/Attendees.php Outdated Show resolved Hide resolved
src/Tribe/Attendees.php Outdated Show resolved Hide resolved
src/Tribe/Attendees.php Outdated Show resolved Hide resolved
src/Tribe/Attendees.php Outdated Show resolved Hide resolved
bordoni
bordoni requested changes Jul 19, 2024
View reviewed changes
src/Tribe/Attendees.php Outdated Show resolved Hide resolved
src/Tribe/Attendees.php Outdated Show resolved Hide resolved
@pattihis pattihis requested review from bordoni and JPry July 19, 2024 11:30
@pattihis pattihis added the code review Status: requires a code review. label Jul 19, 2024
JPry
JPry previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@JPry JPry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pattihis pattihis changed the base branch from bucket/plugin-consolidation to release/T24.centaur August 1, 2024 16:20
@pattihis pattihis dismissed JPry’s stale review August 1, 2024 16:20

The base branch was changed.

@pattihis
Merge branch 'release/T24.centaur' of github.com:the-events-calendar/…
f515c2d 
…event-tickets into fix/Attendees-CSV-Export

# Conflicts:
#	event-tickets.php
#	package.json
#	readme.txt
#	src/Tribe/Main.php
@pattihis
tec_bot comment fix
8f043d6
JPry
JPry requested changes Aug 1, 2024
View reviewed changes
readme.txt Outdated Show resolved Hide resolved
src/Tickets/Flexible_Tickets/Repositories/Event_Repository.php Show resolved Hide resolved
src/Tribe/Attendees.php Show resolved Hide resolved
src/Tribe/Attendees.php Show resolved Hide resolved
src/Tribe/Attendees.php Show resolved Hide resolved
@pattihis pattihis closed this Aug 1, 2024
@pattihis
Copy link
Contributor Author

pattihis commented Aug 1, 2024

Creating a new clean branch based on release/T24.centaur

@pattihis pattihis deleted the fix/Attendees-CSV-Export branch August 1, 2024 19:53
@pattihis pattihis mentioned this pull request Aug 6, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPry JPry JPry requested changes

@bordoni bordoni Awaiting requested review from bordoni

Assignees

@pattihis pattihis

Labels
code review Status: requires a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pattihis @bordoni @JPry @stratease @Camwyn @tec-bot