Feat/support uplink licensing #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucatume
requested changes
Jul 29, 2024
| * | ||
| * @return void | ||
| */ | ||
| public function register_plugin(): void { |
There was a problem hiding this comment.
If the SLR feature is deactivated using the constant set in the wp-config.php file, this registration will not happen since the Uplink\SLR_Controller is registered in the main SLR Controller.
Why not have this controller live in the Seating directory?
I would call the controller Uplink, register as it is registered now in the main Seating controller and be part of the SLR feature completely.
Co-authored-by: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
Co-authored-by: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
lucatume
approved these changes
Jul 30, 2024
…ort-uplink-licensing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
SL-157
🗒️ Description
🎥 Artifacts
✔️ Checklist
npm run changelogto add changelog file(s).wpunitorintegrationtests.wpunitorintegrationtests.