[SL-62] - Block editor capacity table show Assigned seating row. #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…city-table # Conflicts: # src/Tickets/Seating/app/blockEditor/filters.js # src/Tickets/Seating/app/blockEditor/store/index.js
rafsuntaskin
changed the title
…nts-calendar/event-tickets into feat/sl-62-editor-capacity-table
lucatume
requested changes
Jul 30, 2024
| import {addFilter} from "@wordpress/hooks"; | ||
| import { getLocalizedString } from '@tec/tickets/seating/utils'; | ||
|
|
||
| export function filterCapacityTableMappedProps(mappedProps) { |
| const hasSeats = select(storeName).isUsingAssignedSeating(); | ||
| const layoutLocked = select(storeName).isLayoutLocked(); | ||
|
|
||
| if ( ! hasSeats || ! layoutLocked ) { |
There was a problem hiding this comment.
Collect into a !AND.
Suggested change
| if ( ! hasSeats || ! layoutLocked ) { | |
| if ( ! ( hasSeats && layoutLocked ) ) { |
| return mappedProps; | ||
| } | ||
|
|
||
| addFilter( |
There was a problem hiding this comment.
Move this to the filters.js file.
In that file import the filterCapacityTableMappedProps function and hook on the filter.
| @@ -1,2 +1,3 @@ | |||
| import './store'; | |||
| import './filters.js'; | |||
| import './capacity-table'; | |||
There was a problem hiding this comment.
Do not import this file, import only the filters.js one, from that import the function that will hook on the filter.
| 'dashboard' => [ 'seats-action-label' => _x( 'Seats', 'Ticket Dashboard actions', 'event-tickets' ) ], | ||
| 'maps' => [ | ||
| 'capacity-form' => $localization->get_capacity_form_strings(), | ||
| 'capacity-table' => [ 'seats-row-label' => _x( 'Assigned Seating', 'Capacity table row label for assigned seating tickets', 'event-tickets' ) ], |
There was a problem hiding this comment.
This should come up in a snapshot; if not already covered by tests, cover it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
SL-62
🗒️ Description
🎥 Artifacts
📷 screenshot(s): https://share.cleanshot.com/zGW7bt0p
✔️ Checklist
npm run changelogto add changelog file(s).wpunitorintegrationtests.wpunitorintegrationtests.