Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-36] Feat - Deleting attendee with seat reservation should update the reservation info. #3129

Merged
merged 15 commits into from
Jul 30, 2024

Conversation

rafsuntaskin
Copy link
Contributor

@rafsuntaskin rafsuntaskin commented Jul 24, 2024

🎫 Ticket

SL-36

🗒️ Description

If an admin deletes an attendee from the Attendees page or Attendees tab:
-> The attendee is also removed from the list on the Seats tab
-> The associated seat is returned to available

🎥 Artifacts

🎥 screencast(s): https://www.loom.com/share/3a94a69bacd04ebf882ca7e3148bf571

✔️ Checklist

  • Ran npm run changelog to add changelog file(s).
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@rafsuntaskin rafsuntaskin self-assigned this Jul 24, 2024
@rafsuntaskin rafsuntaskin changed the title Feat/sl 36 delete attendee [SL-36] Feat - Deleting attendee with seat reservation should update the reservation info. Jul 25, 2024
@rafsuntaskin rafsuntaskin added the code review Status: requires a code review. label Jul 25, 2024
@rafsuntaskin rafsuntaskin marked this pull request as ready for review July 25, 2024 22:36
$event_id = get_post_meta( $attendee_id, Commerce_Attendee::$event_relation_meta_key, true );
$reservation_id = get_post_meta( $attendee_id, Meta::META_KEY_RESERVATION_ID, true );

if ( ! $reservation_id ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add check for event_id?

Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing condition check.

@rafsuntaskin rafsuntaskin merged commit 1537795 into feat/slr-support Jul 30, 2024
14 of 15 checks passed
@rafsuntaskin rafsuntaskin deleted the feat/sl-36-delete-attendee branch July 30, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Status: requires a code review.
Projects
None yet
2 participants