-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SL-36] Feat - Deleting attendee with seat reservation should update the reservation info. #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Tickets/Seating/Orders/Controller.php # tests/slr_integration/Orders/Controller_Test.php
rafsuntaskin
changed the title
Feat/sl 36 delete attendee
[SL-36] Feat - Deleting attendee with seat reservation should update the reservation info.
Jul 25, 2024
lucatume
approved these changes
Jul 29, 2024
$event_id = get_post_meta( $attendee_id, Commerce_Attendee::$event_relation_meta_key, true ); | ||
$reservation_id = get_post_meta( $attendee_id, Meta::META_KEY_RESERVATION_ID, true ); | ||
|
||
if ( ! $reservation_id ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add check for event_id
?
lucatume
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing condition check.
lucatume
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
SL-36
🗒️ Description
If an admin deletes an attendee from the Attendees page or Attendees tab:
-> The attendee is also removed from the list on the Seats tab
-> The associated seat is returned to available
🎥 Artifacts
🎥 screencast(s): https://www.loom.com/share/3a94a69bacd04ebf882ca7e3148bf571
✔️ Checklist
npm run changelog
to add changelog file(s).wpunit
orintegration
tests.wpunit
orintegration
tests.