Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Old ETWP Upsell Notices #3131

Merged
merged 14 commits into from
Jul 29, 2024
Merged

Update Old ETWP Upsell Notices #3131

merged 14 commits into from
Jul 29, 2024

Conversation

codingmusician
Copy link
Contributor

@codingmusician codingmusician commented Jul 24, 2024 •
edited by jira bot
Loading

🎫 Ticket

ET-2170

🗒️ Description

After merging ETWP into ETP, we found two upsell notices for ETWP in ET. This PR modifies them to be ETP notices.

🎥 Artifacts

image
image

✔️ Checklist

  • Ran npm run changelog to add changelog file(s).
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@codingmusician codingmusician self-assigned this Jul 24, 2024
@codingmusician codingmusician changed the base branch from master to release/T24.centaur July 25, 2024 18:27
@codingmusician codingmusician changed the title Remove and Deprecate ETWP Upsell Notices Update Old ETWP Upsell Notices Jul 25, 2024
@codingmusician codingmusician marked this pull request as ready for review July 29, 2024 14:52
@codingmusician codingmusician added the code review Status: requires a code review. label Jul 29, 2024
redscar
redscar previously approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@redscar redscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good. Should we change the class_exists code to did_action for ETP?

Camwyn
Camwyn requested changes Jul 29, 2024
View reviewed changes
src/Tickets/Admin/Upsell.php Outdated Show resolved Hide resolved
@Camwyn Camwyn added the question Needs an answer to one or more questions before merging. label Jul 29, 2024
Camwyn
Camwyn reviewed Jul 29, 2024
View reviewed changes
src/Tickets/Admin/Upsell.php
@@ -78,23 +80,10 @@ public function show_on_attendees_page() {
return;
}

$has_tickets_plus = class_exists( '\Tribe__Tickets_Plus__Main', false );
$has_wallet_plus = class_exists( '\TEC\Tickets_Wallet_Plus\Plugin', false );
$has_tickets_plus = did_action( 'tec_container_registered_provider_Tribe__Tickets_Plus__Service_Provider' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ticket adding a "tec-tickets-plus-loaded" hook if we need to go this route.

Camwyn
Camwyn requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@Camwyn Camwyn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ft_integration tests are failing...

@codingmusician codingmusician merged commit 8012f7d into release/T24.centaur Jul 29, 2024
15 checks passed
@codingmusician codingmusician deleted the tweak/remove-etwp-upsell-notices branch July 29, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camwyn Camwyn Camwyn approved these changes

@redscar redscar Awaiting requested review from redscar

Assignees

@codingmusician codingmusician

Labels
code review Status: requires a code review. question Needs an answer to one or more questions before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codingmusician @Camwyn @redscar