Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

['ET-2103] Populate Start and End sale dates when creating a new ticket. #3132

Merged

Conversation

redscar
Copy link
Contributor

@redscar redscar commented Jul 25, 2024

🎫 Ticket

ET-2103

🗒️ Description

When creating a new ticket the Start & End date/times would not autopopulate which caused users to have to manually put in the date. Now they will autopopulate with Todays date and tomorrows date.

🎥 Artifacts

image

✔️ Checklist

  • Ran npm run changelog to add changelog file(s).
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@redscar redscar self-assigned this Jul 25, 2024
@redscar redscar marked this pull request as ready for review July 25, 2024 19:26
@redscar redscar added the code review Status: requires a code review. label Aug 1, 2024
@redscar redscar requested a review from a team August 5, 2024 13:09
Copy link
Member

@Camwyn Camwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about gmdate.

src/admin-views/editor/panel/fields/dates.php Outdated Show resolved Hide resolved
@Camwyn Camwyn added the question Needs an answer to one or more questions before merging. label Aug 5, 2024
bordoni
bordoni previously requested changes Aug 5, 2024
src/admin-views/editor/panel/fields/dates.php Outdated Show resolved Hide resolved
@redscar redscar removed the question Needs an answer to one or more questions before merging. label Aug 5, 2024
@redscar redscar requested a review from bordoni August 5, 2024 15:47
@redscar redscar merged commit 25d40d6 into release/T24.chupacabra Aug 5, 2024
15 checks passed
@redscar redscar deleted the tweak/ET-2103_populate_start_end_sale_dates branch August 5, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Status: requires a code review.
Projects
None yet
4 participants