Feat/et 2163 status notices #3210

stratease · 2024-08-29T20:37:48Z

🎫 Ticket

ET-2163

🗒️ Description

Status notices.

🎥 Artifacts

✔️ Checklist

Ran npm run changelog to add changelog file(s). More info here
Code is covered by NEW wpunit or integration tests.
Code is covered by EXISTING wpunit or integration tests.
Are all the required tests passing?
Automated code review comments are addressed.
Have you added Artifacts?
Check the base branch for your PR.
Add your PR to the project board for the release.

src/Tickets/Commerce/Admin/Singular_Order_Page.php

dpanta94

Love it overall! Left a few suggeestions

src/Tickets/Commerce/Admin/Singular_Order_Notices.php

dpanta94 · 2024-08-30T14:31:20Z

tests/commerce_integration/TEC/Admin/Ticket_NoticesTest.php

+
+namespace TEC\Admin;
+
+use Spatie\Snapshots\MatchesSnapshots;


Why this instead of Luca's use tad\Codeception\SnapshotAssertions\SnapshotAssertions

Didn't know there was one - what's the difference here?

I am not really sure. I just consider Luca's like our own. It does offer different methods to compare text, code, html, JSON. It works well inside a dataProvider loop and whatever we need we can just reach out to him via slack :P

tests/commerce_integration/TEC/Admin/Ticket_NoticesTest.php

...ion/TEC/Admin/__snapshots__/Ticket_NoticesTest__messages_should_match with data set 0__1.php

…alendar/event-tickets into feat/ET-2163-status-notices

…events-calendar/event-tickets into feat/ET-2163-status-notices" This reverts commit 2b8d6b0, reversing changes made to d5a19e7.

…com:the-events-calendar/event-tickets into feat/ET-2163-status-notices"" This reverts commit 2badbfa.

dpanta94

Just a phpcs and good to go

/home/runner/work/event-tickets/event-tickets/src/Tickets/Commerce/Admin/Singular_Order_Page.php:73:1:Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed<br>Tabs must be used to indent lines; spaces are not allowed

dpanta94

And some stylelint issues :D

bordoni · 2024-09-23T22:27:33Z

src/Tickets/Commerce/Admin/Singular_Order_Notices.php

+ *
+ * @package TEC\Tickets\Commerce\Admin
+ */
+class Singular_Order_Notices {


I would love to chat tomorrow about this particular implementation before we merge, I have some thoughts on potentially using some other pattern that doesn't involve as many constants.

JPry · 2024-09-23T22:41:30Z

src/Tickets/Commerce/Admin/Singular_Order_Notices.php

+	/**
+	 * @since TBD
+	 *
+	 * @var string Notice key.
+	 */
+	const ORDER_STATUS_SUCCESSFULLY_UPDATED = 'updated';
+	/**


These all need a space between them.

Suggested change

/**

* @since TBD

*

* @var string Notice key.

*/

const ORDER_STATUS_SUCCESSFULLY_UPDATED = 'updated';

/**

/**

* @since TBD

*

* @var string Notice key.

*/

const ORDER_STATUS_SUCCESSFULLY_UPDATED = 'updated';

/**

JPry · 2024-09-23T22:44:45Z

src/Tickets/Commerce/Admin/Singular_Order_Notices.php

+			/**
+			 * Success messages.
+			 */
+			/* translators: %1$s: order number. %2$s: status the order was changed from. %3$s: status the order was changed to. */


For these comments, you don't need to include the extra characters in the placeholders.

Suggested change

/* translators: %1$s: order number. %2$s: status the order was changed from. %3$s: status the order was changed to. */

/* translators: 1: order number 2: status the order was changed from 3: status the order was changed to. */

More context: https://developer.wordpress.org/apis/internationalization/internationalization-guidelines/#variables

…ed approach.

stratease added 2 commits August 29, 2024 21:20

Status updates init.

f60ecf9

Fixed bug with message not undismissing and wrong refund message.

ecec13f

stratease added the code review Status: requires a code review. label Aug 29, 2024

stratease self-assigned this Aug 29, 2024

tec-bot reviewed Aug 29, 2024

View reviewed changes

src/Tickets/Commerce/Admin/Singular_Order_Page.php Show resolved Hide resolved

stratease added 2 commits August 29, 2024 21:42

Added changelog entry.

b8e83ac

Docblock added, renamed function and some cleanup.

1a62652

Camwyn previously approved these changes Aug 29, 2024

View reviewed changes

dpanta94 requested changes Aug 30, 2024

View reviewed changes

Switched assertion, some escaping.

d5a19e7

stratease dismissed Camwyn’s stale review via d5a19e7 September 3, 2024 13:49

stratease requested a review from dpanta94 September 3, 2024 13:49

dpanta94 previously approved these changes Sep 3, 2024

View reviewed changes

Merge branch 'bucket/order-management-p2b' of github.com:the-events-c…

2b8d6b0

…alendar/event-tickets into feat/ET-2163-status-notices

stratease dismissed dpanta94’s stale review via 2b8d6b0 September 18, 2024 15:03

stratease added 4 commits September 18, 2024 16:14

Revert "Merge branch 'bucket/order-management-p2b' of github.com:the-…

2badbfa

…events-calendar/event-tickets into feat/ET-2163-status-notices" This reverts commit 2b8d6b0, reversing changes made to d5a19e7.

Revert "Revert "Merge branch 'bucket/order-management-p2b' of github.…

a981082

…com:the-events-calendar/event-tickets into feat/ET-2163-status-notices"" This reverts commit 2badbfa.

Added missing ticket # from changelog.

6190ce3

Bump our submodules to bucket commits

6c07cce

stratease requested review from dpanta94 and Camwyn September 18, 2024 15:50

dpanta94 previously approved these changes Sep 19, 2024

View reviewed changes

dpanta94 reviewed Sep 19, 2024

View reviewed changes

Fix eslint issues.

c213b45

stratease dismissed dpanta94’s stale review via c213b45 September 23, 2024 12:31

stratease requested a review from dpanta94 September 23, 2024 12:35

bordoni requested changes Sep 23, 2024

View reviewed changes

JPry reviewed Sep 23, 2024

View reviewed changes

Refactored order status admin notices to use a simple class model bas…

d8e9fc3

…ed approach.

Missing use statement.

02e5916

stratease requested a review from bordoni September 26, 2024 18:23

Missing docs and whitespace.

1177bc5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/et 2163 status notices #3210

Feat/et 2163 status notices #3210

stratease commented Aug 29, 2024 •

edited by jira bot

Loading

dpanta94 left a comment

dpanta94 Aug 30, 2024

stratease Sep 3, 2024

dpanta94 Sep 3, 2024

dpanta94 left a comment

dpanta94 left a comment

bordoni Sep 23, 2024

JPry Sep 23, 2024

JPry Sep 23, 2024 •

edited

Loading

JPry Sep 23, 2024

	/* translators: %1$s: order number. %2$s: status the order was changed from. %3$s: status the order was changed to. */
	/* translators: 1: order number 2: status the order was changed from 3: status the order was changed to. */

Feat/et 2163 status notices #3210

Are you sure you want to change the base?

Feat/et 2163 status notices #3210

Conversation

stratease commented Aug 29, 2024 • edited by jira bot Loading

🎫 Ticket

🗒️ Description

🎥 Artifacts

✔️ Checklist

dpanta94 left a comment

Choose a reason for hiding this comment

dpanta94 Aug 30, 2024

Choose a reason for hiding this comment

stratease Sep 3, 2024

Choose a reason for hiding this comment

dpanta94 Sep 3, 2024

Choose a reason for hiding this comment

dpanta94 left a comment

Choose a reason for hiding this comment

dpanta94 left a comment

Choose a reason for hiding this comment

bordoni Sep 23, 2024

Choose a reason for hiding this comment

JPry Sep 23, 2024

Choose a reason for hiding this comment

JPry Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

JPry Sep 23, 2024

Choose a reason for hiding this comment

stratease commented Aug 29, 2024 •

edited by jira bot

Loading

JPry Sep 23, 2024 •

edited

Loading