Chore/testing and ci config #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport fix: Support for WPGraphQL v1.8+ has been added.
lucatume
reviewed
May 5, 2022
borkweb
approved these changes
Aug 10, 2022
includes/class-ql-events.php
Outdated
Comment on lines
165
to
195
| require get_includes_directory() . 'types/interface/class-ticket-interface.php'; | ||
| require get_includes_directory() . 'types/object/common/trait-attendee.php'; | ||
| require get_includes_directory() . 'types/object/common/trait-order.php'; | ||
| require get_includes_directory() . 'types/object/common/trait-ticket.php'; | ||
| require get_includes_directory() . 'types/object/class-event-linked-data-type.php'; | ||
| require get_includes_directory() . 'types/object/class-event-type.php'; | ||
| require get_includes_directory() . 'types/object/class-organizer-linked-data-type.php'; | ||
| require get_includes_directory() . 'types/object/class-organizer-type.php'; | ||
| require get_includes_directory() . 'types/object/class-paypalattendee-type.php'; | ||
| require get_includes_directory() . 'types/object/class-paypalorder-type.php'; | ||
| require get_includes_directory() . 'types/object/class-paypalticket-type.php'; | ||
| require get_includes_directory() . 'types/object/class-rsvpattendee-type.php'; | ||
| require get_includes_directory() . 'types/object/class-rsvpticket-type.php'; | ||
| require get_includes_directory() . 'types/object/class-ticket-linked-data-type.php'; | ||
| require get_includes_directory() . 'types/object/class-venue-linked-data-type.php'; | ||
| require get_includes_directory() . 'types/object/class-venue-type.php'; | ||
| require get_includes_directory() . 'types/object/class-wooattendee-type.php'; | ||
|
|
||
| require get_includes_directory() . 'data/connection/class-attendee-connection-resolver.php'; | ||
| require get_includes_directory() . 'data/connection/class-event-connection-resolver.php'; | ||
| require get_includes_directory() . 'data/connection/class-organizer-connection-resolver.php'; | ||
| require get_includes_directory() . 'data/connection/class-ticket-connection-resolver.php'; | ||
| require get_includes_directory() . 'data/class-factory.php'; | ||
|
|
||
| require get_includes_directory() . 'connection/class-attendees.php'; | ||
| require get_includes_directory() . 'connection/class-events.php'; | ||
| require get_includes_directory() . 'connection/class-organizers.php'; | ||
| require get_includes_directory() . 'connection/class-tickets.php'; | ||
|
|
||
| require get_includes_directory() . 'class-core-schema-filters.php'; | ||
| require get_includes_directory() . 'class-type-registry.php'; |
There was a problem hiding this comment.
Not a necessary change, but a suggested one: Perhaps call get_includes_directory() once and assign to a variable to avoid repeated calls?
kidunot89
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wp-graphql/wp-graphql-testcasepackage added tocomposer.jsonstr_slug()usage in factories replaced withslugify()EventQueriesTest,OrganizerQueriesTest, andVenueQueriesTestto extend the QLEventsTestCase and take advantage of the WPGraphQL Testcase assertions.TODO