Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attendee interface/connections/mutations added. Order interface added. #46

Merged
merged 8 commits into from
Dec 6, 2022
Merged

Attendee interface/connections/mutations added. Order interface added. #46

merged 8 commits into from
Dec 6, 2022

Conversation

kidunot89
Copy link
Collaborator

@kidunot89 kidunot89 commented Jun 16, 2022 •
edited
Loading

Summary

  • Implements Checkout Mutation: attendee ticket fieldsets #36
  • Adds Attendee Interface type along with the attendee connections from RootQuery and Event.
  • Adds OrderInterface (Couldn't rename WooGraphQL's Order type) interface type.
  • Adds Attendee data field for query attendee meta.
  • Adds attendees field to Order type
  • Adds registerAttendee mutation
  • Adds updateAttendee mutation
  • AttendeeQueriesTest and AttendeeMutationsTest implemented.

@kidunot89 kidunot89 marked this pull request as draft June 16, 2022 06:03
@kidunot89 kidunot89 requested a review from borkweb August 30, 2022 22:32
@kidunot89 kidunot89 marked this pull request as ready for review August 30, 2022 22:32
@kidunot89 kidunot89 mentioned this pull request Aug 30, 2022
Merged
@kidunot89 kidunot89 added enhancement New feature or request new query PR implements a new RootQuery field new mutation PR implements a new mutation new type PR implements a new type labels Sep 1, 2022
bordoni
bordoni requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@bordoni bordoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things, the only consideration is that if we are going towards PHP 7.4, we should think about type hinting.

includes/types/interface/class-attendee-interface.php Outdated Show resolved Hide resolved
includes/mutation/class-register-attendee.php Show resolved Hide resolved
includes/connection/class-attendees.php Show resolved Hide resolved
includes/connection/class-attendees.php Show resolved Hide resolved
includes/connection/class-attendees.php Show resolved Hide resolved
@kidunot89 kidunot89 merged commit 1c43b47 into master Dec 6, 2022
@kidunot89 kidunot89 mentioned this pull request Mar 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bordoni bordoni bordoni approved these changes

@borkweb borkweb Awaiting requested review from borkweb

Assignees
No one assigned
Labels
enhancement New feature or request new mutation PR implements a new mutation new query PR implements a new RootQuery field new type PR implements a new type
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kidunot89 @bordoni