Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category text colours are black for visited events. #133

Open
adampatterson opened this issue Sep 1, 2021 · 9 comments
Open

Category text colours are black for visited events. #133

adampatterson opened this issue Sep 1, 2021 · 9 comments

Comments

@adampatterson
Copy link
Contributor

adampatterson commented Sep 1, 2021

I have removed all of my themes CSS when confirming this.

If I create a category with white text, the colours show as expected, once I visit the event the link colour changes to black.

There is some CSS

 .tribe-common article.tribe_events_cat-general h3 a,
 .tribe-common article.tribe_events_cat-general h3 a:link,

Adding

.tribe-common article.tribe_events_cat-general h3 a:visited,

will fix this.

adampatterson added a commit to adampatterson/the-events-calendar-category-colors that referenced this issue Sep 1, 2021
@adampatterson
Copy link
Contributor Author

I set a proposed change, Would love to see this merged in.

Let me know if there are any other areas that might need to fix and I can make that change.

@afragen
Copy link
Collaborator

afragen commented Sep 1, 2021

Do you have a calendar URL I can see this on?

@adampatterson
Copy link
Contributor Author

@afragen yes, this site is a work in progress.

https://wps.bg.bubbleupsandbox.ca/calendar/

Look for Terry Fox

@afragen
Copy link
Collaborator

afragen commented Sep 1, 2021

I see what you mean. Much less than ideal.

@adampatterson
Copy link
Contributor Author

Lol, I did a quick test by modifying my local plugin to confirm that my PR works.

I did see some other areas where the visited link might be affected in the same way but I did not encounter those yet since my theme is custom.

@afragen
Copy link
Collaborator

afragen commented Sep 1, 2021

I just want to check an make sure something similar isn't needed elsewhere, but will merge now.

afragen added a commit that referenced this issue Sep 1, 2021
#133 adds visited CSS to category link colour
@adampatterson
Copy link
Contributor Author

Thanks!

@hjed
Copy link

hjed commented Nov 3, 2021

Hey so this seems to be happening again in the most recent version of the Event Calendar plugin. Looks like event calendar changed their CSS.

Example site: https://sydneynorthscouts.com/events/

This looks like the guilty css:

image

@adampatterson adampatterson changed the title Category text colours are back for visited events. Category text colours are black for visited events. Nov 4, 2021
@nooQsoftware
Copy link

Has there been a fix for this? Still seeing this behaviour. Is there css to override it happening? Want to keep white text on dark backgrounds, even if visited or not. As get black text on dark background after clicked once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants