New telemetry functionality #1992
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camwyn
added
hold
Less logic and less code that way. Also less brittle.
Camwyn
removed
the
needs artifact
Camwyn
commented
Oct 16, 2023
Camwyn
added a commit
to the-events-calendar/the-events-calendar
that referenced
this pull request
Oct 20, 2023
Just keeping the TCMN changes linked. See: the-events-calendar/tribe-common#1992
borkweb
requested changes
Oct 31, 2023
tec-bot
reviewed
Mar 20, 2024
| @@ -245,4 +249,8 @@ public function filter_exit_interview_args( $args ) { | |||
| public function maybe_enqueue_admin_modal_assets(): void { | |||
| $this->container->make( Asset_Subscriber::class )->maybe_enqueue_admin_assets(); | |||
| } | |||
|
|
|||
| public function filter_data_args( $args ) { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function filter_data_args()
| * Text Domain: tribe-common | ||
| * License: GPLv2 or later | ||
| */ | ||
| /* |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Commenting.FileComment.WrongStyle
You must use "/**" style comments for a file comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a stellar-licensing section to the Telemetry JSON:
Also allows plugins to hook in and filter their slug.
See https://github.com/the-events-calendar/events-filterbar/pull/474 for an example.