[SL-157] Support Uplink Licensing #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpanta94
added
needs release
dpanta94
removed
the
needs release
redscar
approved these changes
Jul 16, 2024
dpanta94
removed
needs changelog
redscar
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Approved, the wpunit tests are failing due to the older version of uplink. Once we get the version of uplink correct the tests should pass without issue.
The check tests locally use composer require stellarwp/uplink:dev-feat/fluent-form-builder --prefer-source
This adds the stellarwp/uplink library and configures it.
dpanta94
force-pushed
the
feat/support-uplink-licensing
branch
from
2724dc1
to
f397e06
Compare
lucatume
reviewed
Jul 23, 2024
…-licensing-fix-uopz Uplink - Fix incorrect `uopz_redefine` arguments used within `set_const_value`
lucatume
requested changes
Jul 29, 2024
| @@ -0,0 +1,174 @@ | |||
| <?php | |||
There was a problem hiding this comment.
If all is required by the Uplink functionality is one file, why not move it to the root?
From ./Uplink/Controller.php to ./Uplink.php.
lucatume
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
SL-157
🗒️ Description
Provides a way for Uplink registered plugins to be displayed in License Tab.
It will hide legacy fields when it finds the same plugin being registered through Uplink
🎥 Artifacts
✔️ Checklist
readme.txtfile.wpunitorintegrationtests.wpunitorintegrationtests.