Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of message in answers #55

Merged
merged 2 commits into from
Jul 10, 2017

Conversation

dwarfmaster
Copy link
Contributor

@dwarfmaster dwarfmaster commented Apr 8, 2017

With my version of coqtop The Coq Proof Assistant, version 8.6 (March 2017), messages content may have changed place in the xml. I am thus updating it.
Should also fix #54

@teto
Copy link

teto commented Apr 22, 2017

LGTM I've had problems with this as well with coq 8.5.

@dwarfmaster
Copy link
Contributor Author

poke @trefis

@dadoomer
Copy link

Thank you!

@yilongli
Copy link

Thanks. This patch saves my day. Any reason not to merge it?

@trefis
Copy link
Member

trefis commented Jul 10, 2017

@lucas8 in the code around your change I can see we always access the val field of whatever parse_value returned. We don't anymore with your code. Any reason for that change?

@dwarfmaster
Copy link
Contributor Author

@trefis I don't see what you're speaking about : inside get_answer, the val field of parse_value isn't used anymore. What may cause the misunderstanding is that the type of parse_value depends on the structure of the XML parsed, which apparently changed between the coq versions.

@trefis
Copy link
Member

trefis commented Jul 10, 2017

I misread a call to parse_response as a call to parse_value.

I haven't tested but will trust you that this works, merging.

@trefis trefis merged commit 0dcaeb9 into the-lambda-church:pathogen-bundle Jul 10, 2017
This was referenced Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infos panel displays only a blank line when typed :Coq Check nat.
5 participants