Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poor performance when injecting a large diff #2

Closed
the-mikedavis opened this issue Feb 14, 2022 · 1 comment
Closed

poor performance when injecting a large diff #2

the-mikedavis opened this issue Feb 14, 2022 · 1 comment
Assignees

Comments

@the-mikedavis
Copy link
Owner

Committing a verbose commit (shows diff after scissors) can slow down an editor using tree-sitter-git-commit quite a bit if the diff is very large.

This is probably because:

  • this grammar has pretty small message nodes which become numerous on a big commit file
  • tree-sitter-git-diff is currently injected within those message nodes one-by-one
@the-mikedavis
Copy link
Owner Author

Even a 8000 line verbose commit message is very fast after d046669. I expect that the slow-down was that incremental updates to the injected layers became very expensive when there were thousands of injected git-diff lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant