-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service-worker): add service worker utilities and logging support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arashagp
force-pushed
the
feat/service-worker
branch
from
December 16, 2024 08:06
f021e89
to
d5281f8
Compare
… definitions and improved comments
…service worker notifications
njfamirm
requested changes
Dec 16, 2024
…tracer and package details
…ving unused dependencies
Co-authored-by: arashagp <arash.qardashpoor@gmail.com>
njfamirm
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
مرسی واقعا
njfamirm
added a commit
that referenced
this pull request
Dec 17, 2024
#18) * feat(service-worker): add service worker utilities and logging support * feat(service-worker): refactor imports and add version-checker utility * refactor(service-worker): enhance PWA installation handling with type definitions and improved comments * feat(service-worker): add beforeinstallprompt option and integrate snackbar package * refactor(snackbar): optimize logger and signal instantiation with pure annotations * feat(snackbar): allow 'infinite' duration option for snackbar display * doc(snackbar): update documentation to clarify 'infinite' duration option * refactor(service-worker): update snackbar duration to 'infinite' for service worker notifications * refactor(service-worker): improve AlwatrSignal instantiation with pure annotations * refactor(service-worker): update version and repository directory in package.json * feat(service-worker): add an empty test file for initial setup * refactor(snackbar): simplify default duration assignment in showSnackbar function * doc(service-worker): remove unnecessary comment in main.ts * refactor(service-worker): remove install-pwa.ts file and related functionality * refactor(logger): simplify logger initialization by removing package tracer and package details * refactor(service-worker): remove serviceWorkerNotifyHandler and related functionality * refactor(version-checker): remove isVersionLarger function and related logger usage * refactor(service-worker): remove unused exports from main.ts * refactor(service-worker): clean up package.json and yarn.lock by removing unused dependencies * doc(service-worker): write installation * chore: set correct owner homepage * refactor(service-worker): review and enhance Co-authored-by: arashagp <arash.qardashpoor@gmail.com> * lint: make happy --------- Co-authored-by: S. Amir Mohammad Najafi <njfamirm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tasks