Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service-worker): add service worker utilities and logging support #18

Merged
merged 23 commits into from
Dec 17, 2024

Conversation

arashagp
Copy link
Member

@arashagp arashagp commented Dec 14, 2024

Description

Tasks

  • 📝 Self-Review: Ensure that you have thoroughly reviewed your own code changes.
  • 📚 Code Documentation: Update or create all necessary documentation within the code.
  • 📖 User Guides: Add necessary guides to the help document, including README or other help files (if applicable).
  • 🎨 Formatting: Ensure that the code is properly formatted.
  • 📅 Daily Report: Record the changes in the company's daily report, if applicable.

@arashagp arashagp requested a review from njfamirm as a code owner December 14, 2024 07:23
@arashagp arashagp force-pushed the feat/service-worker branch from f021e89 to d5281f8 Compare December 16, 2024 08:06
packages/snackbar/src/lib/handler.ts Outdated Show resolved Hide resolved
packages/service-worker/src/main.ts Outdated Show resolved Hide resolved
packages/service-worker/src/lib/install-pwa.ts Outdated Show resolved Hide resolved
packages/service-worker/src/lib/logger.ts Outdated Show resolved Hide resolved
packages/service-worker/src/lib/logger.ts Outdated Show resolved Hide resolved
packages/service-worker/src/lib/version-checker.ts Outdated Show resolved Hide resolved
packages/service-worker/README.md Outdated Show resolved Hide resolved
packages/service-worker/src/lib/service-worker-notify.ts Outdated Show resolved Hide resolved
packages/service-worker/package.json Outdated Show resolved Hide resolved
Copy link
Member

@njfamirm njfamirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

مرسی واقعا

@njfamirm njfamirm merged commit d428086 into next Dec 17, 2024
2 checks passed
@njfamirm njfamirm deleted the feat/service-worker branch December 17, 2024 06:15
njfamirm added a commit that referenced this pull request Dec 17, 2024
#18)

* feat(service-worker): add service worker utilities and logging support

* feat(service-worker): refactor imports and add version-checker utility

* refactor(service-worker): enhance PWA installation handling with type definitions and improved comments

* feat(service-worker): add beforeinstallprompt option and integrate snackbar package

* refactor(snackbar): optimize logger and signal instantiation with pure annotations

* feat(snackbar): allow 'infinite' duration option for snackbar display

* doc(snackbar): update documentation to clarify 'infinite' duration option

* refactor(service-worker): update snackbar duration to 'infinite' for service worker notifications

* refactor(service-worker): improve AlwatrSignal instantiation with pure annotations

* refactor(service-worker): update version and repository directory in package.json

* feat(service-worker): add an empty test file for initial setup

* refactor(snackbar): simplify default duration assignment in showSnackbar function

* doc(service-worker): remove unnecessary comment in main.ts

* refactor(service-worker): remove install-pwa.ts file and related functionality

* refactor(logger): simplify logger initialization by removing package tracer and package details

* refactor(service-worker): remove serviceWorkerNotifyHandler and related functionality

* refactor(version-checker): remove isVersionLarger function and related logger usage

* refactor(service-worker): remove unused exports from main.ts

* refactor(service-worker): clean up package.json and yarn.lock by removing unused dependencies

* doc(service-worker): write installation

* chore: set correct owner homepage

* refactor(service-worker): review and enhance

Co-authored-by: arashagp <arash.qardashpoor@gmail.com>

* lint: make happy

---------

Co-authored-by: S. Amir Mohammad Najafi <njfamirm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants