Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: snackbar #20

Merged
merged 6 commits into from
Dec 17, 2024
Merged

refactor: snackbar #20

merged 6 commits into from
Dec 17, 2024

Conversation

njfamirm
Copy link
Member

@njfamirm njfamirm commented Dec 17, 2024 •
edited
Loading

Description

Tasks

  • 📝 Self-Review: Ensure that you have thoroughly reviewed your own code changes.
  • 📚 Code Documentation: Update or create all necessary documentation within the code.
  • 📖 User Guides: Add necessary guides to the help document, including README or other help files (if applicable).
  • 🎨 Formatting: Ensure that the code is properly formatted.
  • 📅 Daily Report: Record the changes in the company's daily report, if applicable.
  • 🔄 Rebase: Ensure your branch is rebased and updated based on the default branch.
  • ⬆️ GitHub Project & Assignee: Ensure this pull request is correctly assigned and added to the appropriate GitHub project with the correct status.
  • ✅ Local Deployment Testing (If Applicable): If the changes affect the application's functionality, deploy and test the application locally to ensure it functions as expected.

njfamirm and others added 5 commits December 17, 2024 10:00
@njfamirm
docs: same style for all
f73ae46
@njfamirm @arashagp
refactor(snackbar): review and enhance
9de596e 
Co-authored-by: arashagp <arash.qardashpoor@gmail.com>
@njfamirm @arashagp
refactor(snackbar): separation files and remove function action butto…
2d5fdf7 
…n handler params

Co-authored-by: arashagp <arash.qardashpoor@gmail.com>
@njfamirm @arashagp
refactor(snackbar): separation of concern
76b980a 
Co-authored-by: arashagp <arash.qardashpoor@gmail.com>
@njfamirm @arashagp
refactor(snackbar): remove click signal handler
f676771 
Co-authored-by: arashagp <arash.qardashpoor@gmail.com>
@njfamirm njfamirm requested a review from Copilot December 17, 2024 08:04
@njfamirm njfamirm self-assigned this Dec 17, 2024
Copilot
Copilot AI reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated 2 comments.

Files not reviewed (6)
  • packages/snackbar/package.json: Language not supported
  • packages/snackbar/src/lib/element.ts: Evaluated as low risk
  • packages/typescript-config/README.md: Evaluated as low risk
  • packages/prettier-config/README.md: Evaluated as low risk
  • packages/eslint-config/README.md: Evaluated as low risk
  • README.md: Evaluated as low risk

packages/snackbar/src/lib/handler.ts Outdated Show resolved Hide resolved
packages/snackbar/README.md Outdated Show resolved Hide resolved
@njfamirm njfamirm requested a review from arashagp December 17, 2024 08:23
@njfamirm njfamirm merged commit 9119678 into next Dec 17, 2024
2 checks passed
@njfamirm njfamirm deleted the feat/snackbar branch December 17, 2024 08:23
njfamirm added a commit that referenced this pull request Dec 17, 2024
@njfamirm
refactor: snackbar (#20)
e452745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@arashagp arashagp Awaiting requested review from arashagp

Assignees

@njfamirm njfamirm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@njfamirm