Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mptcp: add support for MP_TCPRST #918

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Conversation

dcaratti
Copy link
Contributor

dissect the MP_TCPRST sub-option in accordance to RFC8684 §3.6.

Link: multipath-tcp/mptcp_net-next#189
Signed-off-by: Davide Caratti dcaratti@redhat.com

Copy link

@matttbe matttbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Davide for working on that!
It looks good to me, just 2 very small details, it would be fine without them but up to you ;-)

print-mptcp.c Outdated Show resolved Hide resolved
print-mptcp.c Outdated Show resolved Hide resolved
Copy link

@matttbe matttbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this patch :-)

Looks good to me for the MPTCP part, hopefully to TCPDump maintainers as well :)

print-mptcp.c Outdated Show resolved Hide resolved
dissect the MP_TCPRST sub-option in accordance to RFC8684 §3.6.

Link: multipath-tcp/mptcp_net-next#189
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
@mcr
Copy link
Member

mcr commented Jul 12, 2021

Will merge when Appveyor checks complete. They are always slow.

@mcr mcr self-assigned this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants