Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tooltips for keys with a shortName #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kyleshay
Copy link

Hi! This diff is just a suggestion, feel free to close if you like.

I noticed that tooltips are only being shown today, but only sometimes — for example, if a key name doesn't fit within the key cap.

It's not always intuitive (for a beginner like myself) to know what all of the short hand names map to.

This diff just always shows tooltips for items that have a shortName specified in src/utils/key.ts. It's a bit weird because it's kind of a side-effect of having a shortName specified, but in turn it makes things a bit easier for when you're hovering over caps.

There's ~318 keys in src/utils/key.ts and 44 of them specify a shortName.

image

@kyleshay
Copy link
Author

I just came across #175/#105 — I guess we'd need to coordinate on what's desired here. That PR ends up effectively doing the same (but ends up making every single key have a tooltip.)

Maybe it ends up being something similar to the little bar that's shown on hover in the key list frame so you're not spammed w/ tooltips, eg:
Screenshot by Dropbox Capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant