Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDOBAO folder move #1240

Merged
merged 10 commits into from
Jul 24, 2022
Merged

IDOBAO folder move #1240

merged 10 commits into from
Jul 24, 2022

Conversation

silvinor
Copy link
Contributor

@silvinor silvinor commented Apr 21, 2022

I hope you will grace us the opportunity to do some branding cleanup. Basically we're just moving all the IDOBAO keyboards to the idobao folder. This is so that IDOBAO kb's can all be in one location as they are releasing a whole lot more soon.

Description

A few file moves and 2 minor brand name correction:

  • Move Idobo to the idobao/id75 folder + corrected the branding. "Idobo" was a typo made by Drop way back and it was never corrected. "IDOBAO" (all uppercase) is the correct branding.
  • Corrected ID96 "Idobao" brand to "IDOBAO"
  • Move other/id67 to the idobao/id67 folder
  • Move other/id80 variants (2x) to the idobao/id80 folder
  • Move other/id87 to the idobao/id87 folder
  • Move other/montex27 to the idobao/montex folder & renamed the json to montex.json

QMK Pull Request

All folder moves for the IDOBAO brand have already been done. Please see issue #15658 for a list of already merged PR's on this.

Checklist

ⓘ -- No changes to the json files have been made except "name": fields where branding corrections where made if needed.

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@yiancar
Copy link
Collaborator

yiancar commented Jul 24, 2022

Cheers and thanks!:)

@yiancar yiancar merged commit d803ec9 into the-via:master Jul 24, 2022
@silvinor silvinor deleted the vr-idobao-folder-mv branch July 24, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants