Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add via support for Tata80 #1615

Merged
merged 7 commits into from
Jan 18, 2023
Merged

add via support for Tata80 #1615

merged 7 commits into from
Jan 18, 2023

Conversation

spbgzh
Copy link
Contributor

@spbgzh spbgzh commented Jan 3, 2023 •
edited
Loading

Description

QMK Pull Request

qmk/qmk_firmware#19445

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@yiancar
Copy link
Collaborator

yiancar commented Jan 10, 2023

As explained before the whole checklist must be completed. I will close this PR for now and please comment once QMK has been merged.
Cheers:)

@yiancar yiancar closed this Jan 10, 2023
@spbgzh
Copy link
Contributor Author

spbgzh commented Jan 18, 2023

@yiancar Dear sir the qmk PR was merged, please reopen this PR please!

@yiancar yiancar reopened this Jan 18, 2023
@yiancar yiancar merged commit 59bcec5 into the-via:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spbgzh @yiancar