Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add config file for dactyl-manuform 4x6 #1661

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

AnotherStranger
Copy link
Contributor

@AnotherStranger AnotherStranger commented Jan 23, 2023

Description

I added a config for the 4x6 dactyl manuform keyboard.

QMK Pull Request

The QMK PR is pending:
qmk/qmk_firmware#19668

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@yiancar
Copy link
Collaborator

yiancar commented Jan 24, 2023

As this is pending I will close this PR until the checklist is fully completed. Once so please ping a comment and I will open it back up.

@yiancar yiancar closed this Jan 24, 2023
@AnotherStranger
Copy link
Contributor Author

@yiancar the pull request linked got merged!
Please re-open and re-review this PR. Thanks a lot!

@AnotherStranger
Copy link
Contributor Author

@yiancar bump ;-)

@yiancar yiancar reopened this Feb 3, 2023
@yiancar
Copy link
Collaborator

yiancar commented Feb 3, 2023

Cheers! sorry I didnt see it until the bump:)

@yiancar yiancar merged commit fc99443 into the-via:master Feb 3, 2023
@AnotherStranger
Copy link
Contributor Author

Cheers! sorry I didnt see it until the bump:)

Nothing to be sorry about!
Thank you for your help and awesome work! I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants