Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0xCB Tutelpad #1740

Closed
wants to merge 10 commits into from
Closed

Add 0xCB Tutelpad #1740

wants to merge 10 commits into from

Conversation

beelzebubi
Copy link
Contributor

Description

Added layout for the Tutelpad macropad by 0xCB

QMK Pull Request

qmk_firmware#16975

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@beelzebubi
Copy link
Contributor Author

Sorry, I seem to have a scrambled forked repo. Only the last commit is the one of interest.

@yiancar
Copy link
Collaborator

yiancar commented Mar 9, 2023

Please make the CI pass:)

@beelzebubi
Copy link
Contributor Author

CI now passed the tests.

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your V3 json file is not going into the correct folder. it must be placed in the v3 folder not the V3 folder. case is important

@beelzebubi
Copy link
Contributor Author

Okay, I've got no clue why the folder on the repo is in upper cases. Locally its in v3. As I don't really know how to fix this, I will close this pr, rebuild my repo and open another pr.

@beelzebubi beelzebubi closed this Mar 13, 2023
@beelzebubi beelzebubi mentioned this pull request Mar 13, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants