Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keymap v2 and v3 for soda/mango #1893

Closed
wants to merge 3 commits into from
Closed

Add keymap v2 and v3 for soda/mango #1893

wants to merge 3 commits into from

Conversation

jaaronkot
Copy link
Contributor

@jaaronkot jaaronkot commented Jun 6, 2023 •
edited
Loading

Description

Add keymap v2 and v3 for soda/mango

QMK Pull Request

qmk/qmk_firmware#21100 (comment)

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Jun 11, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete v2 definition as this is not a legacy keyboard (src/ folder json)

Are you sure this is correct?
image

v3/soda/mango/mango.json Outdated Show resolved Hide resolved
@jaaronkot jaaronkot force-pushed the master branch 2 times, most recently from 3046ed5 to 57347ab Compare June 11, 2023 13:26
@jaaronkot
Copy link
Contributor Author

Please delete v2 definition as this is not a legacy keyboard (src/ folder json)

Are you sure this is correct? image

This is not a problem and has no impact on the operation of my keyboard.

@jaaronkot jaaronkot closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaaronkot @Xelus22 @gezhaoyou