Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Skyloong/Dt40 keyboard #2006

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Add Skyloong/Dt40 keyboard #2006

merged 4 commits into from
Sep 11, 2023

Conversation

JZ-Skyloong
Copy link
Contributor

Description

QMK Pull Request

qmk/qmk_firmware#21237

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@JZ-Skyloong JZ-Skyloong changed the title Dt40 Add Skyloong/Dt40 keyboard Aug 31, 2023
Xelus22
Xelus22 requested changes Sep 2, 2023
View reviewed changes
v3/skyloong/dt40/dt40.json Show resolved Hide resolved
@JZ-Skyloong JZ-Skyloong requested a review from Xelus22 September 5, 2023 08:31
@Xelus22 Xelus22 merged commit 24c4ecc into the-via:master Sep 11, 2023
@JZ-Skyloong JZ-Skyloong deleted the dt40 branch September 14, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JZ-Skyloong @Xelus22