Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding sakura workshop fuji75 hotswap and solder pcb supports #2120

Merged
merged 4 commits into from
Feb 11, 2024
Merged

adding sakura workshop fuji75 hotswap and solder pcb supports #2120

merged 4 commits into from
Feb 11, 2024

Conversation

CMMS-Freather
Copy link
Contributor

adding sakura workshop fuji75 hotswap and solder pcb supports

adding sakura workshop fuji75 hotswap and solder pcb supports

QMK Pull Request

qmk/qmk_firmware#22158

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

CMMS-Freather and others added 2 commits July 12, 2023 00:55
@CMMS-Freather
adding ah haven 65 & haven 80 via json
172e450
@CMMS-Freather
adding fuji75 pcb via support
8565fba 
adding fuji75 via pcb support
includes
hotswap
solder
@CMMS-Freather CMMS-Freather reopened this Dec 14, 2023
Xelus22
Xelus22 requested changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

Just the Fuji75 folder is uppercase. Please change to lowercase to reflect QMK tree structure/naming

@CMMS-Freather
Copy link
Contributor Author

Everything looks good.

Just the Fuji75 folder is uppercase. Please change to lowercase to reflect QMK tree structure/naming

renamed and updated

@CMMS-Freather CMMS-Freather requested a review from Xelus22 February 6, 2024 09:30
@Xelus22 Xelus22 merged commit b791fb4 into the-via:master Feb 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CMMS-Freather @Xelus22