Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Via for the Sofle #337

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Enable Via for the Sofle #337

merged 2 commits into from
Oct 19, 2020

Conversation

Sturek
Copy link
Contributor

@Sturek Sturek commented Sep 25, 2020

Description

Created a mapping for the Sofle. Includes underglow support.

QMK Pull Request

qmk/qmk_firmware#10446

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Sturek Sturek changed the title Dev Enable Via for the Sofle Sep 26, 2020
@Sturek
Copy link
Contributor Author

Sturek commented Oct 2, 2020

The changes in QMK have been merged.

Copy link
Contributor

@2Moons-JP 2Moons-JP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks the right hand may be backwards when compared to the QMK .h file and the Keymap. Does it work on hardware ok? If so disregard. 5,5 here is R00 in QMK not R05.

@Sturek
Copy link
Contributor Author

Sturek commented Oct 10, 2020

I will double check, but I have been using this JSON with the hardware and it works fine. My guess is that this has to do with the fact that the PCB is reversible?

@Sturek
Copy link
Contributor Author

Sturek commented Oct 10, 2020

Yeah, it works fine and the matrix test also shows everything correctly.

@wilba wilba merged commit 606debe into the-via:master Oct 19, 2020
@fsargent
Copy link

fsargent commented May 6, 2021

Not sure if something's changed but the layout is a bit different for my sofle. Play/Mute are the encoders in the image. The left thumb row is shifted over by one. I can't really understand how to fix it, is there a tool, or is it done just by json array modification?
image

@Sturek
Copy link
Contributor Author

Sturek commented May 24, 2021

I am not sure I can follow. If your Sofle looks different and the keys in VIA don't fit the physical layout, you may have the v2 version of the Sofle. This is for the v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants