Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDOBAO ID80 #96

Merged
merged 2 commits into from
May 3, 2020
Merged

Add IDOBAO ID80 #96

merged 2 commits into from
May 3, 2020

Conversation

sigprof
Copy link
Contributor

@sigprof sigprof commented Apr 14, 2020

Description

Add IDOBAO ID80 keyboard (id80 in QMK). This is a 75% hotswap keyboard with a fixed ANSI layout (no layout options). The PCB supports RGB underglow (LEDs are presoldered, but none of the LEDs, including the 4 extra RGB LEDs on the top surface, are properly visible after assembly, because the case does not have any transparent elements) and single-color key backlight (requires soldering through-hole in switch LEDs, which are not included in the kit).

QMK Pull Request

Basic support for ID80: qmk/qmk_firmware#8728 (already merged).
VIA keymap: qmk/qmk_firmware#8791 (already merged)
QMK matrix layout update: qmk/qmk_firmware#8930

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Apr 17, 2020
@sigprof
Copy link
Contributor Author

sigprof commented Apr 25, 2020

The QMK PR qmk/qmk_firmware#8791 was merged.

@sigprof
Copy link
Contributor Author

sigprof commented Apr 26, 2020

After some more thinking, maybe this should not be merged in the current state. I found that the ROW2COL matrix layout, which is used by this keyboard currently, can result in about 2x slower scan rate than the COL2ROW layout, and now I'm thinking about transposing the matrix (swapping rows and columns) to make it COL2ROW; however, the VIA layout would also need to be redone in this case.

The QMK PR qmk/qmk_firmware#8930 changes the
matrix layout used by the IDOBAO ID80 keyboard (the matrix is
transposed, so that the faster COL2ROW scan routines may be used).
Update the VIA layout definition according to these changes.
@sigprof
Copy link
Contributor Author

sigprof commented Apr 26, 2020

I updated the VIA layout according to the QMK changes in qmk/qmk_firmware#8930 (pending at the moment).

@wilba wilba merged commit 37877f9 into the-via:master May 3, 2020
@sigprof sigprof deleted the id80 branch January 8, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants