修复获取用户名称后未去除空白字符导致黑名单无法匹配的问题 #4353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- feat: 播放器顶部留白自定义数值 - fix: 限制组件仅在播放页执行 减少无意义DOM操作
- 动态创建自定义事件并通过dispatchEvent派发 - 仅在播放器模式发生变化时派发事件
- 监听全局事件playerModeChange 并修改样式 - 为什么不用静态CSS：弹幕列表的marginTop在不同宽度设备是不同的，具体规则并不确定，需要用JS即时获取 - #4178
- 之前是通过获取`#danmukuBox`原始`marginTop`来设置UP主信息的`marginTop`的 - 现在可以通过实时计算 获得目标`marginTop`值 - 用于计算的代码来自B站混淆后的内联JS 做了一些适应性修改
- 之前展示的是完整路径 当路径过长时会导致提示信息过长 选取体验很差 - 做统一截取处理 只展示能够区分当前组件的部分
the1812
reviewed
Aug 2, 2023
| const likeButton = e.closest('.bili-dyn-item__main').querySelector('.bili-dyn-action.like') | ||
| return likeButton && !likeButton.classList.contains('active') ? likeButton : [] | ||
| }) | ||
| // 固定dom路径，提升性能 |
There was a problem hiding this comment.
这么改提升不了多少性能, b 站要是哪天多套个 div 这一段代码就要炸了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.