Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

def: define biimplications #457

Merged
merged 11 commits into from
Jan 16, 2025
Merged

def: define biimplications #457

merged 11 commits into from
Jan 16, 2025

Conversation

TOTBWF
Copy link
Collaborator

@TOTBWF TOTBWF commented Jan 13, 2025

Description

This PR defines a type of biimplications, and proves some basic properties.

Checklist

Before submitting a merge request, please check the items below:

  • I've read the contributing guidelines.
  • The imports of new modules have been sorted with support/sort-imports.hs (or nix run --experimental-features nix-command -f . sort-imports).
  • All new code blocks have "agda" as their language.

If your change affects many files without adding substantial content, and
you don't want your name to appear on those pages (for example, treewide
refactorings or reformattings), start the commit message and PR title with chore:.

@TOTBWF TOTBWF requested review from ncfavier and plt-amy January 13, 2025 16:19
@Lavenza
Copy link
Member

Lavenza commented Jan 14, 2025

Pull request preview

Changed pages

@ncfavier
Copy link
Member

We can link this from https://preview.1lab.dev/457/1Lab.Equiv.html#propositional-extensionality-redux now. Also maybe worth mentioning the name "logical equivalence".

src/1Lab/Biimp.lagda.md Outdated Show resolved Hide resolved
@TOTBWF
Copy link
Collaborator Author

TOTBWF commented Jan 15, 2025

Not sure what's up with the build failure; runs fine locally.

@TOTBWF
Copy link
Collaborator Author

TOTBWF commented Jan 15, 2025

Ok looks like something is a bit flaky with the build system... Probably worth looking into.

@TOTBWF TOTBWF requested a review from ncfavier January 15, 2025 23:08
@TOTBWF TOTBWF merged commit 5eab18d into main Jan 16, 2025
5 checks passed
@TOTBWF TOTBWF deleted the biimplication branch January 16, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants