Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution: fix hard-coded link to section #664

Closed
Blackstareye opened this issue Nov 21, 2023 · 2 comments
Closed

Contribution: fix hard-coded link to section #664

Blackstareye opened this issue Nov 21, 2023 · 2 comments

Comments

@Blackstareye
Copy link
Contributor

https://github.com/theNewDynamic/gohugo-theme-ananke/blob/c086834f0ebfa39b8b6b0cfed010588a6907a91c/layouts/index.html#L13C31-L13C31

At the moment, only the first mainsection will be shown in the index.

I changed it so that the mainsections will be iterated with "range $mainsections".
This allows that multiple sections are possible and can be displayed.

I will link this issue in the PR

grafik
@Blackstareye Blackstareye mentioned this issue Nov 21, 2023
Merged
regisphilibert pushed a commit that referenced this issue Apr 18, 2024
@Blackstareye
Contribution: fix hard-coded link to section #664 (#665)
f34c219 
* allow_multiple_mainsection

* removed comment

---------

Co-authored-by: Blackeye <>
@ramiro
Copy link
Contributor

ramiro commented Apr 25, 2024

Shouldn't this issue be closed as fixed?

@Blackstareye
Copy link
Contributor Author

yes

ramiro added a commit to ramiro/gohugo-theme-ananke that referenced this issue Apr 30, 2024
@ramiro
Revert " Contribution: fix hard-coded link to section theNewDynamic#664…
66187cf 
… (theNewDynamic#665)"

This reverts commit f34c219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramiro @Blackstareye