Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git submodules #183

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Use git submodules #183

merged 1 commit into from
Sep 3, 2019

Conversation

ndastur
Copy link
Contributor

@ndastur ndastur commented Jul 10, 2019

As per https://gohugo.io/getting-started/quick-start/ I think it is better to use git submodules rather than cloning the repo. It should be easier to keep up to date etc. So please consider this change in documentation

As per https://gohugo.io/getting-started/quick-start/ I think it is better to use git submodules rather than cloning the repo. It should be easier to keep up to date etc. So please consider this change in documentation
@budparr
Copy link
Member

budparr commented Sep 2, 2019

Thank you. I think a lot of users will have a difficult time with Git submodules. I'm happy to add this as an alternative, but not in replace of the cloning method.

@ndastur
Copy link
Contributor Author

ndastur commented Sep 2, 2019

Agreed git sub-modules are a PITA but it's the officially documented way to deal with themes in Hugo and for the initial clone no real difference. The difference comes when you want to update from the repo. At that point "users" who have done a git clone essentially get stuck. As it is difficult to update the code into their own site's repo.

Can I make a suggestion that if you keep the git clone rather than the submodule. Could you please add instructions on how to keep code up to date from your repository after cloning and creating a user's own site.

BTW great theme and thanks for putting the theme out there under MIT.

@budparr
Copy link
Member

budparr commented Sep 3, 2019

Thanks. Actually, I'm going to go with your change. I may add some language to it later though.

@budparr budparr merged commit e791596 into theNewDynamic:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants