Social icon updates #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bdashrad
commented
Sep 22, 2017
bdashrad
commented
- Add LinkedIn
- Fix github svg spacing
- Update colors to ones from brandcolors.net
adambkaplan
reviewed
Sep 26, 2017
| @@ -20,6 +20,11 @@ | |||
| {{ partial "svg/youtube.svg" (dict "size" $icon_size) }} | |||
| </a> | |||
| {{ end }} | |||
| {{ with .Site.Params.linkedin }} | |||
| <a href="{{ . }}" class="link-transition linkedin link dib z-999 pt3 pt0-l mr3" title="LinkedIn link"> | |||
There was a problem hiding this comment.
I've personally found the mr3 spacing is a bit wide.
There was a problem hiding this comment.
good catch. i was just about to push a fix but it was just merged.
|
Hi guys. Looks like two competing PRs? I'm going to try to pull these in, but FYI I'm working Ananke 2.0, which will break these changes slightly. |
Closed
|
Yep - competing. @bdashrad and I seem to have wanted to add GH and LinkedIn at the same time 😺 |
|
Is the substantive difference the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.