complete the feature for the cover dimming class in page #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for gohugo-ananke-theme-demo failed. Why did it fail? →
|
|
This too, force push (git push origin --force) and Netlify should run. |
- feature already present for site - add info for the param to the example Signed-off-by: Patrick Kollitsch <patrick@davids-neighbour.com>
Signed-off-by: Patrick Kollitsch <patrick@davids-neighbour.com>
davidsneighbour
force-pushed
the
patch-2
branch
from
f1c6666 to
2ed5c55
Compare
✅ Deploy Preview for ananke-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Patrick Kollitsch <patrick@davids-neighbour.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Like #702, this PR wants to add the cover class to the page as well, but adds also the documentation to the example and allows both for page params and site params.
Explain the details for making this change. What existing problem does the pull request solve?
Solves #696 in a proper way for site and page with fallback and documentation in the example.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Default:
Same as default
cover_dimming_class = bg-black-60:cover_dimming_class = bg-black-20:cover_dimming_class = bg-black-90:Code formatting
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes.closes #702
closes #696