Fonts: Fine tune preload, retire prefetch
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefetchhas been a mistake, we should have always used preload.This replaces the
prefetchkey setting bypreloadThere is a few things to consider:
Loading ALL font formats is a bad practice, for now we'll limit preloading to
woff2files, as this is the most efficient and supported format. There's very few reasons for a user not to have awoff2file. (We'll give more freedom in the future).We also ensure the font-face ordering is now:
woff2,woff,ttfetc...Fixes #63