Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with to avoid error in parse #7

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

loic-roux-404
Copy link
Contributor

@loic-roux-404 loic-roux-404 commented Jan 1, 2021

First thanks for sharing this tool, it's very useful.

When using your tool i had encountered this error. it's simply missing a {{ with . }} that you are using in {{ else if reflect.IsMap . }} condition below

Error i had in partials/admin/private/parse.html:33:14

error calling partialCached: partial that returns a value needs a non-zero argument.

When using your tool i had encountered this error. it's simply missing a `{{ with . }}` that you use in ` {{ else if reflect.IsMap . }}
` below
error calling partialCached: partial that returns a value needs a non-zero argument.
@regisphilibert
Copy link
Member

Hi @loic-roux-404 and sorry for seeing this so late... I have fixed this in v0.1.7... Maybe your version is anterior to this?

@loic-roux-404
Copy link
Contributor Author

loic-roux-404 commented Feb 15, 2021

You fixed it in another place

But error is also possible on the line i had edited.

@regisphilibert
Copy link
Member

Oh awesome! Thank you for that! I'll review shortly!

@regisphilibert regisphilibert merged commit 27a9135 into theNewDynamic:main Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants