Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ios): fix 'FBSDKCoreKit/FBSDKCoreKit-swift.h' file not found on case-sensitive filesystems #458

Merged
merged 1 commit into from
Oct 18, 2023
Merged

docs(ios): fix 'FBSDKCoreKit/FBSDKCoreKit-swift.h' file not found on case-sensitive filesystems #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ Follow ***steps 2, 3 and 4*** in the [Getting Started Guide](https://developers.
```objc
#import <AuthenticationServices/AuthenticationServices.h>
#import <SafariServices/SafariServices.h>
#import <FBSDKCoreKit/FBSDKCoreKit-swift.h>
#import <FBSDKCoreKit/FBSDKCoreKit-Swift.h>
```
2. Inside `didFinishLaunchingWithOptions`, add the following:
```objc
Expand Down Expand Up @@ -160,7 +160,7 @@ The `AppDelegate.m` file can only have one method for `openUrl`. If you're also
```objc
#import <AuthenticationServices/AuthenticationServices.h> // <- Add This Import
#import <SafariServices/SafariServices.h> // <- Add This Import
#import <FBSDKCoreKit/FBSDKCoreKit-swift.h> // <- Add This Import
#import <FBSDKCoreKit/FBSDKCoreKit-Swift.h> // <- Add This Import
#import <React/RCTLinkingManager.h> // <- Add This Import

- (BOOL)application:(UIApplication *)app
Expand Down Expand Up @@ -304,7 +304,7 @@ If you would like to initialize the Facebook SDK even earlier in startup for iOS
```objective-c
#import <AuthenticationServices/AuthenticationServices.h> // <- Add This Import
#import <SafariServices/SafariServices.h> // <- Add This Import
#import <FBSDKCoreKit/FBSDKCoreKit-swift.h> // <- Add This Import
#import <FBSDKCoreKit/FBSDKCoreKit-Swift.h> // <- Add This Import

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
Expand Down
2 changes: 1 addition & 1 deletion RNFBSDKExample/ios/RNFBSDKExample/AppDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#import <AuthenticationServices/AuthenticationServices.h>
#import <SafariServices/SafariServices.h>
#import <FBSDKCoreKit/FBSDKCoreKit-swift.h>
#import <FBSDKCoreKit/FBSDKCoreKit-Swift.h>
#import <React/RCTLinkingManager.h>

#import <React/RCTBundleURLProvider.h>
Expand Down
2 changes: 1 addition & 1 deletion refresh-example.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ sed -i -e 's/<\/application>/ <meta-data android:name="com.facebook.sdk.Applica
rm -f android/app/src/main/AndroidManifest.xml??

# FBSDK requires a few imports, and you probably want to see if Facebook can handle a link, so facebook logins work...
sed -i -e 's/#import "AppDelegate.h"/#import "AppDelegate.h"\n#import <FBSDKCoreKit\/FBSDKCoreKit-swift.h>\n#import <React\/RCTLinkingManager.h>/' ios/RNFBSDKExample/AppDelegate.mm
sed -i -e 's/#import "AppDelegate.h"/#import "AppDelegate.h"\n#import <FBSDKCoreKit\/FBSDKCoreKit-Swift.h>\n#import <React\/RCTLinkingManager.h>/' ios/RNFBSDKExample/AppDelegate.mm
rm -f ios/RNFBSDKExample/AppDelegate.mm??
sed -i -e 's/#import "AppDelegate.h"/#import "AppDelegate.h"\n#import <SafariServices\/SafariServices.h>/' ios/RNFBSDKExample/AppDelegate.mm
rm -f ios/RNFBSDKExample/AppDelegate.mm??
Expand Down
Loading