Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump iOS SDK version to 17.0.0 #506

Merged
merged 4 commits into from
Apr 10, 2024
Merged

chore: bump iOS SDK version to 17.0.0 #506

merged 4 commits into from
Apr 10, 2024

Conversation

efstathiosntonas
Copy link
Contributor

@efstathiosntonas efstathiosntonas changed the title bump iOS SDK version to 17.0.0 chore: bump iOS SDK version to 17.0.0 Mar 29, 2024
@15matias15 15matias15 mentioned this pull request Apr 2, 2024
Closed
@efstathiosntonas
Copy link
Contributor Author

@thebergamo besides the building issues, version 17 supports the new requirements for Apple privacy manifests.

@joaquinvaz
Copy link

Any plans to merge this one?

@RKakushev
Copy link

RKakushev commented Apr 9, 2024 •
edited
Loading

Have it tested to crash free? Cause it may contains breaking changes on native fbsdk library due changing major version from 16 to 17. @efstathiosntonas

@mikehardy
Copy link
Collaborator

@RKakushev you can test this and let us know if it's crash free, right? Stated differently: It's open source - if you have a question, do the work and answer it, no one here is working for you, you are working for yourself. Would love to know your results

I'll see about merging

@RKakushev
Copy link

@RKakushev you can test this and let us know if it's crash free, right? Stated differently: It's open source - if you have a question, do the work and answer it, no one here is working for you, you are working for yourself. Would love to know your results

I'll see about merging

Yes you are right. I just interested about it. Thank you for your work.

@mikehardy
Copy link
Collaborator

Quick thoughts

  • this will be a breaking change because privacy manifests implies a new minimum cocoapods version (1.12 IIRC? easy to meet, but cocoapods has no min spec'd yet)
  • I believe it also requires newer min versions of other chunks of toolchain which everyone has to meet to get privacy manifests anyway, but still a breaking change is a breaking change

No big deal there, this is mostly a note to myself.

  • I need to bump some things in the workflow to modern runner versions and modern actions. Just finished doing that in a few other repos so shouldn't be too onerous but will take some time

mikehardy added a commit that referenced this pull request Apr 10, 2024
@mikehardy
test(ci): use macos-latest for iOS build
3ff1849 
was `macOS-latest` and somehow this resulted in macos-12 image
being used, which did not work well

See #506
mikehardy added a commit that referenced this pull request Apr 10, 2024
@mikehardy
test(ci): use macos-14 for iOS build
a60e164 
was `macOS-latest` and somehow this resulted in macos-12 image
being used, which did not work well

Note that the all-lowercase `macos-latest` still resulted in macos-12
runner despite the github documentation specifying that macos-latest
should be macos-14 at this point

See #506
@mikehardy mikehardy mentioned this pull request Apr 10, 2024
Merged
mikehardy added a commit that referenced this pull request Apr 10, 2024
@mikehardy
test(ci): use macos-14 for iOS build
4f080ac 
was `macOS-latest` and somehow this resulted in macos-12 image
being used, which did not work well

Note that the all-lowercase `macos-latest` still resulted in macos-12
runner despite the github documentation specifying that macos-latest
should be macos-14 at this point

See #506
@mikehardy mikehardy force-pushed the bump_ios_sdk_to_17_0_0 branch from fb7c6d4 to 68f7f89 Compare April 10, 2024 19:34
@mikehardy mikehardy added the pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. label Apr 10, 2024
@mikehardy
Copy link
Collaborator

beat my way through all the CI problems and github going down in the interim, great fun.
Seems to work locally and CI should work on it now as well after rebasing from the work results and pushing this PR back

Hopefully all goes ✅

@efstathiosntonas
Copy link
Contributor Author

Thank you Mike for your hard work!

Don't know if it's worth mentioning on release notes but it seems like a breaking change to me:

facebook/facebook-ios-sdk#2365 (comment)

@mikehardy
Copy link
Collaborator

@efstathiosntonas indeed, I'll rebase / reword the commit to include that information, re-push then merge
Got some other PRs going through first that are non-breaking first

efstathiosntonas and others added 4 commits April 10, 2024 15:25
@efstathiosntonas @mikehardy
feat(ios)!: adopt facebook-ios-sdk version 17.0.0
a34dfe6 
`16.3.1` version has issues with Xcode 15.3:
 -  facebook/facebook-ios-sdk#2353

BREAKING CHANGE: upstream login / limited login functionality changed,
https://developers.facebook.com/blog/post/2024/03/28/changes-made-to-fb-login-sdk/
instructs how to adapt. Most likely you will want to switch to
the relatively new "Limited Login" functionality.
@mikehardy
build(deps)!: minimum cocoapods version increased to 1.12.0
e7cfdb6 
BREAKING CHANGE: cocopaods >= 1.12 is required for privacy manifests
@mikehardy
feat(android)!: adopt facebook-android-sdk 17.0.0
ea06a69 
BREAKING CHANGE: upstream notes are vague, but they say:
"More use case for Integrity is supported. Apps violating
Meta’s Policy will no longer be allowed to send Traffic"
@mikehardy
build(deps, android): bump android SDK compile / target to current
477b65d 
these and the android plugin change should be overridden by project
config, but if not, they are current now
@mikehardy mikehardy force-pushed the bump_ios_sdk_to_17_0_0 branch from 68f7f89 to 477b65d Compare April 10, 2024 20:26
@mikehardy mikehardy merged commit 66bac90 into thebergamo:master Apr 10, 2024
4 checks passed
@mikehardy mikehardy removed the pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. label Apr 10, 2024
@mikehardy
Copy link
Collaborator

cleared the decks in this repo, all PRs merged+released, hopefully the repo goes to sleep for a while again :-)

Cheers

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efstathiosntonas @joaquinvaz @RKakushev @mikehardy