Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Deeplink ordering note added to README.md #587

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Asad520
Copy link
Contributor

@Asad520 Asad520 commented Dec 13, 2024

ISSUE
My app has multiple SSO options set up. When I added Facebook SSO using this package, it worked fine for Android and some iOS devices as well. But for some iOS devices, the app navigates to the Facebook app to authenticate and switches back to my app with a deep link like fbAppId://somePermissions%data%etc.

After debugging for an entire day, I realized that I had put RCTLinkinganager condition before FBSDKApplicationDelegate and just changing the order fixed it.

I believe this short note would be helpful for anyone having multiple other SSOs while integrating this package

@Asad520 Asad520 changed the title Deeplink ordering note added to README.md docs: Deeplink ordering note added to README.md Dec 13, 2024
@Asad520
Copy link
Contributor Author

Asad520 commented Dec 15, 2024

@mikehardy Can you take a look at this, please?

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit :-) - thank you

@mikehardy mikehardy added the pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. label Dec 17, 2024
@mikehardy mikehardy merged commit 09233b8 into thebergamo:master Dec 17, 2024
4 checks passed
@mikehardy mikehardy removed the pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants